Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asp.net Identity 2.0 #9

Closed
JonKragh opened this issue Feb 20, 2014 · 10 comments
Closed

Asp.net Identity 2.0 #9

JonKragh opened this issue Feb 20, 2014 · 10 comments

Comments

@JonKragh
Copy link

Hi -

Thanks for this project! I see you have a v2 branch.

Do you have a list of of tasks for this release?

I may be able to help.

Thanks,
Jon

@jsheely
Copy link
Contributor

jsheely commented Feb 20, 2014

Nothing formally added. I'm simply reviewing the beta release of the Microsoft.AspNet.Identity.Core and Microsoft.AspNet.Identity.EntityFramework that was released on 2/14/2014 and trying to mimic it's implementation.

You can read the details here: http://blogs.msdn.com/b/webdev/archive/2014/02/11/announcing-preview-of-microsoft-aspnet-identity-2-0-0-beta1.aspx

Right now the issue I'm working on is deciding how to best implement the ability to have the identity property be a generic. Being that it must be a ObjectId in MongoDB.

@JonKragh
Copy link
Author

Awesome! Thanks for working on this! I added Query.EQ("_id", ObjectId.Parse(userId.ToString()) to the various places to get the v2 version to compile and added in the IdentityRole, etc to the project file. I'm able to compile. I'd like to future proof myself with a new side project that would include email address as a property.

Do you think I should try to use the v2 stuff in your opinion?

Thanks!

@jsheely
Copy link
Contributor

jsheely commented Feb 20, 2014

Yea I checked in v2 in an instable state just so people could see that it's moving a long.

So with the new v2 release Microsoft allows you to change which property is the primary key. So I'm working on implementing that for MongoDB which would mean something other than _id would be the primary key.

Email address has always been a property you could add to the ApplicationUser model and would work fine. All the v2 did was add it as a first class citizen through an optional interface which the EF implementation utilizes.

The interface gives you some out of the box utilities to query for a user by email. Which again you could have easily implemented yourself but now you don't have too.

@JonKragh
Copy link
Author

Great info! If you were starting a side project today that would launch in say 2 weeks (an MVP)...which package do you recommend? Main branch or V2 and work through issues? Appreciate your work brotha!

@jsheely
Copy link
Contributor

jsheely commented Feb 20, 2014

Personally I'd start with v1. Everything in v2 to can migrated to. Most of the heavy lifting is in the AccountController methods anyway for features like say: what to do when a user wants to say reset their password.

That combined with the fact that v2 is still officially in beta and I haven't finished building out the MongoDB v2 provider yet.

You'll be able to move much faster on your own product if you're not waiting / fixing non-mission critical functionality.

@JonKragh
Copy link
Author

Sounds like great advice man! Really appreciate it!

@joshgarwood
Copy link

Hey guys! Hope all is well. I am wondering if either of you have had luck with v1 or v2. I tried v1 and got an error when the user was committed to the database as it seems the id for the user was a Guid as opposed to an ObjectId. So I jumped in and tried to wrangle with v2 and am having some issues (as is to be expected, but I wanted to give it a shot since the official version 2 of the MS Identity Provider released on 03/20 I believe).

At any rate, I would greatly appreciate any insight you may have as to why v1 would be failing with the error mentioned above.

Thanks for your time!!

PS: I mentioned this in an issue I filed #13 (the title is misleading... it really is just about the GetUserId returning a Guid instead of an ObjectId).

@JanickRoss
Copy link

The v2 is released :) Do you have an ETA for the upgrade and support all official features ?

@jsheely
Copy link
Contributor

jsheely commented Mar 27, 2014

No official ETA. I'll probably be poking at it again this weekend. It's almost there as it is. Just needs to resolve the optional selection of the ID property and some other loose ends.

@jsheely
Copy link
Contributor

jsheely commented Apr 7, 2014

V2 is getting closer. I've created another issue

#14 (Items to complete for V2)

We can track future updates to v2 there.

@jsheely jsheely closed this as completed Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants