You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the work on this. I found a bug while I was "borrowing" your existing work and thought I would help. I don't plan to use this library verbatim at this point so instead of submitting a commit I will just comment below:
The UserStore FindAsync implementation is incorrect. Although the query will probably match the user most of the time it will yield the wrong user in some cases. It is also not as performant as the suggested change.
Should be changed to use ElemMatch which actually compares two values of the same element of an array instead of two distinct properties of any of the array values.
I haven't tested the change but I do know ElemMatch is what should be used for a query on multiple properties of a single array element. Wanted to let you know before I moved on. Thanks again for the work on this!
The text was updated successfully, but these errors were encountered:
Thanks for the work on this. I found a bug while I was "borrowing" your existing work and thought I would help. I don't plan to use this library verbatim at this point so instead of submitting a commit I will just comment below:
The UserStore FindAsync implementation is incorrect. Although the query will probably match the user most of the time it will yield the wrong user in some cases. It is also not as performant as the suggested change.
Should be changed to use ElemMatch which actually compares two values of the same element of an array instead of two distinct properties of any of the array values.
I haven't tested the change but I do know ElemMatch is what should be used for a query on multiple properties of a single array element. Wanted to let you know before I moved on. Thanks again for the work on this!
The text was updated successfully, but these errors were encountered: