Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE-643] Enhacemenets for subscription components endpoints #56

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[DE-643] Enhacemenets for subscription components endpoints #56

merged 2 commits into from
Dec 11, 2023

Conversation

maciej-nedza
Copy link
Contributor

@maciej-nedza maciej-nedza commented Dec 11, 2023 •
edited
Loading

  • make allocated_quantity both integer and string
  • reuse ComponentKind where possible
  • datetime format for Subscription Component

@swarmia Swarmia
Copy link

swarmia bot commented Dec 11, 2023

✅  Linked to DE-643 · Add needed enhancements to OAS file
➡️  Part of Story DE-578 · Java test CRUD for Subscription Components endpoints part 1
➡️  Part of Epic DE-117 · SDK Testing
➡️  Part of DE-113 · OneMaxio API

@maciej-nedza maciej-nedza marked this pull request as ready for review December 11, 2023 13:36
@maciej-nedza maciej-nedza merged commit 1447618 into main Dec 11, 2023
2 checks passed
@maciej-nedza maciej-nedza deleted the publish branch December 11, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpierog michalpierog michalpierog approved these changes

@patryk-grudzien-keen patryk-grudzien-keen patryk-grudzien-keen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciej-nedza @michalpierog @patryk-grudzien-keen @maxio-sdk