Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE-563] Components endpoints tests 1 #48

Merged
merged 7 commits into from
Dec 5, 2023
Merged

[DE-563] Components endpoints tests 1 #48

merged 7 commits into from
Dec 5, 2023

Conversation

maciej-nedza
Copy link
Contributor

No description provided.

@swarmia Swarmia
Copy link

swarmia bot commented Dec 4, 2023

✅  Linked to Story DE-563 · Java test CRUD for Components endpoints part 1
➡️  Part of Epic DE-117 · SDK Testing
➡️  Part of DE-113 · OneMaxio API

@maciej-nedza maciej-nedza marked this pull request as ready for review December 4, 2023 16:56
patryk-grudzien-keen
patryk-grudzien-keen requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@patryk-grudzien-keen patryk-grudzien-keen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments.

...test/java/com/maxio/advancedbilling/controllers/components/ComponentsControllerTestBase.java Outdated Show resolved Hide resolved
...test/java/com/maxio/advancedbilling/controllers/components/ComponentsControllerTestBase.java Outdated Show resolved Hide resolved
...test/java/com/maxio/advancedbilling/controllers/components/ComponentsControllerTestBase.java Outdated Show resolved Hide resolved
...test/java/com/maxio/advancedbilling/controllers/components/ComponentsControllerFindTest.java Show resolved Hide resolved
...t/java/com/maxio/advancedbilling/controllers/components/ComponentsControllerArchiveTest.java Outdated Show resolved Hide resolved
...ncedbilling/controllers/components/ComponentsControllerUpdateProductFamilyComponentTest.java Outdated Show resolved Hide resolved
@maciej-nedza maciej-nedza merged commit 0db9bb8 into main Dec 5, 2023
2 checks passed
@maciej-nedza maciej-nedza deleted the components-tests-1 branch December 5, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patryk-grudzien-keen patryk-grudzien-keen patryk-grudzien-keen approved these changes

@michalpierog michalpierog Awaiting requested review from michalpierog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciej-nedza @patryk-grudzien-keen