-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE-572] + [DE-599] Java CRUD for Product Price Points endpoints part 1 & 2 #45
Merged
patryk-grudzien-keen
merged 1 commit into
main
from
patryk-crud-for-product-price-points
Dec 4, 2023
Merged
[DE-572] + [DE-599] Java CRUD for Product Price Points endpoints part 1 & 2 #45
patryk-grudzien-keen
merged 1 commit into
main
from
patryk-crud-for-product-price-points
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Linked to Story DE-572 · Java CRUD for Product Price Points endpoints part 1 |
maciej-nedza
reviewed
Dec 4, 2023
.../advancedbilling/controllers/productpricepoints/ProductPricePointsControllerArchiveTest.java
Outdated
Show resolved
Hide resolved
maciej-nedza
reviewed
Dec 4, 2023
...vancedbilling/controllers/productpricepoints/ProductPricePointsControllerBulkCreateTest.java
Outdated
Show resolved
Hide resolved
maciej-nedza
reviewed
Dec 4, 2023
...vancedbilling/controllers/productpricepoints/ProductPricePointsControllerBulkCreateTest.java
Show resolved
Hide resolved
maciej-nedza
reviewed
Dec 4, 2023
...trollers/productpricepoints/ProductPricePointsControllerCreateProductCurrencyPricesTest.java
Outdated
Show resolved
Hide resolved
maciej-nedza
reviewed
Dec 4, 2023
...xio/advancedbilling/controllers/productpricepoints/ProductPricePointsControllerReadTest.java
Outdated
Show resolved
Hide resolved
maciej-nedza
reviewed
Dec 4, 2023
...xio/advancedbilling/controllers/productpricepoints/ProductPricePointsControllerReadTest.java
Outdated
Show resolved
Hide resolved
maciej-nedza
previously approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, consider changing beforeEach
s to beforeAll
s and creating entities inside the test when it's needed to be unshared
michalpierog
previously approved these changes
Dec 4, 2023
patryk-grudzien-keen
changed the title
[DE-572] Java CRUD for Product Price Points endpoints part 1
[DE-572] + [DE-599] Java CRUD for Product Price Points endpoints part 1 & 2
Dec 4, 2023
patryk-grudzien-keen
dismissed stale reviews from michalpierog and maciej-nedza
via
December 4, 2023 14:29
f86c76c
patryk-grudzien-keen
force-pushed
the
patryk-crud-for-product-price-points
branch
from
December 4, 2023 14:29
faefa69
to
f86c76c
Compare
maciej-nedza
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for all the endpoints related to
Product Price Points
.