Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE-572] + [DE-599] Java CRUD for Product Price Points endpoints part 1 & 2 #45

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

patryk-grudzien-keen
Copy link
Contributor

@patryk-grudzien-keen patryk-grudzien-keen commented Dec 1, 2023

Tests for all the endpoints related to Product Price Points.

Copy link

swarmia bot commented Dec 1, 2023

✅  Linked to Story DE-572 · Java CRUD for Product Price Points endpoints part 1
➡️  Part of Epic DE-117 · SDK Testing
➡️  Part of DE-113 · OneMaxio API

maciej-nedza
maciej-nedza previously approved these changes Dec 4, 2023
Copy link
Contributor

@maciej-nedza maciej-nedza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider changing beforeEachs to beforeAlls and creating entities inside the test when it's needed to be unshared

michalpierog
michalpierog previously approved these changes Dec 4, 2023
@patryk-grudzien-keen patryk-grudzien-keen changed the title [DE-572] Java CRUD for Product Price Points endpoints part 1 [DE-572] + [DE-599] Java CRUD for Product Price Points endpoints part 1 & 2 Dec 4, 2023
@patryk-grudzien-keen patryk-grudzien-keen merged commit 56dd6a8 into main Dec 4, 2023
2 checks passed
@patryk-grudzien-keen patryk-grudzien-keen deleted the patryk-crud-for-product-price-points branch December 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants