[DE-572] Tests for listing and creating Product(s) Price Points #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story DE-572 · Java CRUD for Product Price Points endpoints part 1 |
michalpierog
requested changes
Nov 30, 2023
...o/advancedbilling/controllers/productpricepoints/ProductPricePointsControllerCreateTest.java
Show resolved
Hide resolved
...o/advancedbilling/controllers/productpricepoints/ProductPricePointsControllerCreateTest.java
Outdated
Show resolved
Hide resolved
| () -> assertThat(defaultPricePoint.getTrialPriceInCents()).isNull(), | ||
| () -> assertThat(defaultPricePoint.getTrialInterval()).isNull(), | ||
| () -> assertThat(defaultPricePoint.getTrialIntervalUnit()).isNull(), | ||
| () -> assertThat(defaultPricePoint.getTrialType()).isEqualTo("payment_expected"), |
There was a problem hiding this comment.
Seems like possible candidate for Enum.
There was a problem hiding this comment.
I'll verify that and fix it in the other PR.
.../advancedbilling/controllers/productpricepoints/ProductPricePointsControllerListAllTest.java
Outdated
Show resolved
Hide resolved
.../advancedbilling/controllers/productpricepoints/ProductPricePointsControllerListAllTest.java
Outdated
Show resolved
Hide resolved
patryk-grudzien-keen
force-pushed
the
patryk-crud-for-product-price-points
branch
from
e3ec7cb
to
f20c7eb
Compare
michalpierog
previously approved these changes
Nov 30, 2023
patryk-grudzien-keen
force-pushed
the
patryk-crud-for-product-price-points
branch
from
f20c7eb
to
1bc7ea8
Compare
michalpierog
approved these changes
Nov 30, 2023
patryk-grudzien-keen
deleted the
patryk-crud-for-product-price-points
branch
patryk-grudzien-keen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.