Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE-582] DE-749 - Improvements in the Account Balance, Prepayment models and "createPrepayment" endpoint #123

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[DE-582] DE-749 - Improvements in the Account Balance, Prepayment models and "createPrepayment" endpoint #123

merged 1 commit into from
Mar 5, 2024

Conversation

patryk-grudzien-keen
Copy link
Contributor

  • Added missing fields in the Account Balance model and added error schema for "createPrepayment" endpoint when 422 response
  • Added int64 format for Created Prepayment model, changed response status from 200 to 201 for Create Prepayment endpoint

@swarmia Swarmia
Copy link

swarmia bot commented Mar 5, 2024

✅  Linked to Story DE-582 · [Java] CRUD for Subscription Invoice Account endpoints Part 1
➡️  Part of Epic DE-677 · Java SDK test coverage increased to 50%
➡️  Part of DE-113 · OneMaxio API

maciej-nedza
maciej-nedza approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@maciej-nedza maciej-nedza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a readme changed a lot 😮

@michalpierog
Copy link
Contributor

Seems like a readme changed a lot 😮

This is expected as we are removing those parts to Dev Portal.

@patryk-grudzien-keen patryk-grudzien-keen merged commit afea64d into main Mar 5, 2024
2 checks passed
@patryk-grudzien-keen patryk-grudzien-keen deleted the publish branch March 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpierog michalpierog michalpierog approved these changes

@maciej-nedza maciej-nedza maciej-nedza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patryk-grudzien-keen @michalpierog @maciej-nedza @maxio-sdk