Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE-631] DE-741 - Fixes to Subscription Components Price Points and Allocations #118

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[DE-631] DE-741 - Fixes to Subscription Components Price Points and Allocations #118

merged 1 commit into from
Feb 29, 2024

Conversation

patryk-grudzien-keen
Copy link
Contributor

@patryk-grudzien-keen patryk-grudzien-keen commented Feb 29, 2024 •
edited
Loading

Changes:

  • Added missing fields in the Allocation model
  • Added missing 404 errors for subscription components endpoints
  • Renamed components price points related models to match the proper camelCase style
  • Changed includeNextProformaInvoice param type from String to an enum

@swarmia Swarmia
Copy link

swarmia bot commented Feb 29, 2024

✅  Linked to Task DE-741 · Add needed enhancements to OAS file
➡️  Part of Story DE-631 · [Java] CRUD for Subscription Components endpoints part 3
➡️  Part of Epic DE-677 · Java SDK test coverage increased to 50%
➡️  Part of DE-113 · OneMaxio API

@patryk-grudzien-keen patryk-grudzien-keen merged commit 3a93074 into main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciej-nedza maciej-nedza maciej-nedza approved these changes

@michalpierog michalpierog Awaiting requested review from michalpierog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patryk-grudzien-keen @maciej-nedza @maxio-sdk