Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

fix analytics circular import #324

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix analytics circular import #324

merged 1 commit into from
Oct 9, 2023

Conversation

the-newman
Copy link
Contributor

No description provided.

Copy link
Member

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably fine. yolo

@the-newman the-newman merged commit 86a9763 into master Oct 9, 2023
5 checks passed
@the-newman the-newman deleted the fix-analytics-import branch October 9, 2023 16:30
@the-newman
Copy link
Contributor Author

thanks for the review @sumnerevans

@th0mcat
Copy link

th0mcat commented Oct 17, 2023

Just a note that I am still getting the error when pulling the latest docker container.

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/lib/python3.11/site-packages/mautrix_facebook/__main__.py", line 26, in <module>
    from .analytics import init as init_analytics
  File "/usr/lib/python3.11/site-packages/mautrix_facebook/analytics.py", line 10, in <module>
    from . import user as u
  File "/usr/lib/python3.11/site-packages/mautrix_facebook/user.py", line 59, in <module>
    from . import portal as po, puppet as pu
  File "/usr/lib/python3.11/site-packages/mautrix_facebook/portal.py", line 71, in <module>
    from .analytics import track
ImportError: cannot import name 'track' from partially initialized module 'mautrix_facebook.analytics' (most likely due to a circular import) (/usr/lib/python3.11/site-packages/mautrix_facebook/analytics.py)

docker-compose:

  mautrix-facebook:
    image: dock.mau.dev/mautrix/facebook:v0.5.1
    container_name: mautrix-facebook
    hostname: mautrix-facebook
    networks:
      dockerapps:
        ipv4_address: 172.18.0.18
    restart: unless-stopped
    volumes:
      - /etc/timezone:/etc/timezone:ro 
      - "/opt/mautrix/facebook:/data"
    depends_on:
      - mautrix-discord
    logging: *default_logging
    labels:
      - homepage.group=Matrix
      - homepage.name=Facebook bridge
      - homepage.icon=facebook.png
      -  "com.centurylinklabs.watchtower.enable=true"

Digest:

$ sudo docker inspect --format='{{index .RepoDigests 0}}' dock.mau.dev/mautrix/facebook:latest
dock.mau.dev/mautrix/facebook@sha256:491a07f8b10ce7b7dc254a519edae0583360c6e35fce6bffa2f36a455e97de30

@tulir
Copy link
Member

tulir commented Oct 17, 2023

Sounds like you didn't pull properly 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants