Add cache-related CLI options #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `value_hint`s to both `--config-file` and `--cache-dir` CLI options. This should provide shells such as zsh and fish with a hint how to complete these arguments.
Before this change the value of `--cache-dir` CLI option was ignored. Now it overrides the value loaded from the TOML config, as it should.
This commit add new `--no-cache` CLI flag which, if set, disables caching for current command invocation. This flag takes priority over and overrides the `--cache-dir` option.
This commit adds new CLI flag `--offline`. Under the _offline_ mode, the API client won't issue any HTTP requests and will only rely on the local cache. In case the cache does not contain requested data, an error is reported. Note that the CLI option cannot be combined with `--no-cache` (for obvious reasons) and that disabling the cache via `--cache-dir` will in turn disable the offline mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following CLI changes:
value_hints to both--config-fileand--cache-dirCLI options--cache-diroption--no-cacheCLI flag which disables local caching--offlinemode under which the app won't issue any API requests and will only rely on the local cache