fix(api): ensure that endpoint path is versioned #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitly API deprecated endpoint paths without specific API version (e.g., `https://api-ssl.bitly.com/shorten`). By mistake, the API client used to make such requests and got 410 (GONE) responses back. This commit fixes this issue by correctly constructing an API endpoint URL which includes the API version (e.g, `https://api-ssl.bitly.com/v4/shorten`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitly API deprecated endpoint paths without specific API version (e.g.,
https://api-ssl.bitly.com/shorten). By mistake, the API client used to make such requests and got 410 (GONE) responses back.This PR fixes this issue by correctly constructing an API endpoint URL which includes the API version (e.g,
https://api-ssl.bitly.com/v4/shorten).