Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect transliteration for Kyiv #98

Open
ksmarko opened this issue Jun 16, 2023 · 5 comments
Open

Incorrect transliteration for Kyiv #98

ksmarko opened this issue Jun 16, 2023 · 5 comments

Comments

@ksmarko
Copy link

ksmarko commented Jun 16, 2023

According to the Ukrainian transliteration rules, the correct value is Kyiv (not Kiev)

@mattjohnsonpint
Copy link
Owner

Please provide the code that is giving you the undesirable result.

@ksmarko
Copy link
Author

ksmarko commented Aug 18, 2023

@mattjohnsonpint You can find all references of "Kiev" and replace them with "Kyiv". Here is the search results: https://github.com/search?q=repo%3Amattjohnsonpint%2FTimeZoneNames+Kiev&type=code.
Also, I get this error when trying to search time zone by name "Europe/Kyiv":
NodaTime.TimeZones.DateTimeZoneNotFoundException: 'Time zone Europe/Kyiv is unknown to source TZDB: 2019c (mapping: 14742)'

@oserdiuk
Copy link

Hi @mattjohnsonpint , are there any updates on this?

@mattjohnsonpint
Copy link
Owner

A few things:

  • It's not this library's responsibility to determine what names are valid or not. It simply presents the data from the latest IANA, CLDR, and Windows source data that was available at time of release.
  • There will always be references to Kiev in the code and data - because Europe/Kiev will always be a valid IANA time zone identifier for backwards compatibility, even though Europe/Kyiv is also valid and preferred.
  • IANA 2019c is outdated, and Europe/Kyiv was added in 2022b. You're likely using an outdated version of NodaTime or NodaTime data in your code. You didn't supply the code that gave that error, so I can't be more specific.

That said, some of the Kiev spellings may have been updated already with CLDR 43, and I haven't updated TimeZoneNames since CLDR 42 - so I'll get on that soon. It also looks like CLDR 44 is around the corner (their releases are twice annually), so there may be multiple updates to TimeZoneNames accordingly.

@mattjohnsonpint
Copy link
Owner

Tracking CLDR updates in #101 and #102. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants