Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviations are unreliable #91

Open
mattjohnsonpint opened this issue Feb 17, 2023 · 0 comments
Open

Abbreviations are unreliable #91

mattjohnsonpint opened this issue Feb 17, 2023 · 0 comments
Assignees
Labels

Comments

@mattjohnsonpint
Copy link
Owner

mattjohnsonpint commented Feb 17, 2023

While names work fine, there are several problems with time zone abbreviations returned by this library.

And more that have come up without being logged.

In general, there are a few causes:

  • CLDR doesn't have abbreviations for every time zone. It has some of them, but they are scattered haphazardly throughout the data. The example in facing Daylight issue for some countires #90 shows how a time zone only has a single daylight abbreviation and no standard or generic abbreviation.
  • We could use TZDB abbreviations as a fallback, but we don't. The problem there is that only English abbreviations exists, and in many cases there's just a numeric offset with no abbreviation. Additionally, it's impossible to know which abbreviation or offset should be used generically if the standard and daylight values differ. Even then - we have to resort to only using the current set of values, not historical ones.
  • The search algorithm in this library probably could be improved

Ultimately I think the solution is either:

  • Find a more reliable source of time zone abbreviation data
  • Remove all abbreviations capabilities from this library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant