Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mattermost-enterprise-edition] Chart behavior changed regarding global.features.database.existingDatabaseSecret in latest helm versions #425

Open
hdeadman opened this issue Oct 30, 2023 · 1 comment

Comments

@hdeadman
Copy link

Running with recent release of helm 3.13.1 the output for MM_CONFIG env variable is bad:
helm template -name mattermost mattermost/mattermost-enterprise-edition

        - name: MM_CONFIG
          valueFrom:
            secretKeyRef:
              name:
              key:

Running with helm 3.9.0 you get the intended output:
helm390 template -name mattermost mattermost/mattermost-enterprise-edition

        - name: MM_CONFIG
          valueFrom:
            secretKeyRef:
              name: mattermost-mattermost-enterprise-edition-mattermost-dbsecret
              key: mattermost.dbsecret

From the deployment app template:

{{- if .Values.global.features.database.existingDatabaseSecret }}
  name: {{ .Values.global.features.database.existingDatabaseSecret.name }}
  key: {{ .Values.global.features.database.existingDatabaseSecret.key }}
{{- else }}
  name: {{ include "mattermost-enterprise-edition.fullname" . }}-mattermost-dbsecret
  key: mattermost.dbsecret
{{- end }}

From the values.yaml

global:
  features:
    database:

      existingDatabaseSecret:
        name:
        key:

It seems like the latest version of helm doesn't treat the existingDatabaseSecret map with two blank keys as "false".

The values.yaml should probably be changed to:

      existingDatabaseSecret: {}
#        name:
#        key:
@hdeadman
Copy link
Author

On a related subject, if you were to try to use an existingDatabaseSecret, since not using one is broken, it will try to use the database secret as the license file location (in config.tpl):

        "LicenseFileLocation": "/mattermost/{{.Values.global.features.database.existingDatabaseSecret.key | default "mattermost.mattermost-license" }}",

@hdeadman hdeadman changed the title Chart behavior changed regarding global.features.database.existingDatabaseSecret in latest helm versions [mattermost-enterprise-edition] Chart behavior changed regarding global.features.database.existingDatabaseSecret in latest helm versions Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant