-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart needs a new Service in order to support calls #384
Comments
Could you please elaborate more your proposal? |
@stafot Calls plugin required UDP port 8443 to be exposed - https://docs.mattermost.com/configure/calls-deployment.html |
Operator (to me) seems like overkill. In my (simple) scenario I just needed to add the mentioned service. |
Yes an additional service with a related flag to enable it on demand seems as reasonable proposal. Feel free to propose it in a pull request if you are in a rush. |
+1 would be great to add to the chart. Presumably since the Calls plugin is still in beta it should live behind a flag. In my case I went with NodePort which is why I specified port apiVersion: v1
kind: Service
metadata:
name: mattermost-rtc-service
spec:
ports:
- nodePort: 30001
port: 30001
protocol: UDP
selector:
app.kubernetes.io/instance: mattermost ## should match the Helm name of your Mattermost deployment Why In my view the main pro of In testing I noticed that Mattermost clients appear to automatically load custom RTC port config from the server anyway, so a 'weird' port like 3000whatever may not matter anyway b/c it's not a user-facing detail. |
Actually RTC works for me by some magic; I see UTC traffic between my and
node addresses and have no idea how it reach pod - there is no services and
pod do not use host address. My best idea is 1) my machine send udp packet
towards server, priecing my firewall and NAT and at same time 2) pod send
UDP packet towards me, piercing nodes iptables (i.e. creating firewall
state to pass traffic, so both sides create states in firewalls to pass
traffic.
For some network configurations such 'magic' isn't possible and some
service needed.
пт, 2 дек. 2022 г., 0:10 Pat ***@***.***>:
… +1 would be great to add to the chart. Presumably since the Calls plugin
is still in beta it should live behind a flag.
In my case I went with NodePort
<https://kubernetes.io/docs/concepts/services-networking/service/#nodeport-custom-port>
which is why I specified port 30001 in my manifest:
apiVersion: v1kind: Servicemetadata:
name: mattermost-rtc-servicespec:
ports:
- nodePort: 30001
port: 30001
protocol: UDP
selector:
app.kubernetes.io/instance: mattermost ## should match the Helm name of your Mattermost deployment
Why 30001? Because those are the rules
<https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport>
for NodePorts.
In my view the main pro of NodePorts is that they are cloud provider
agnostic and should be generally available; the con is running on a 'weird'
port. Pro of LoadBalancer is that it works on default port 8443, but con
is LoadBalancers are 1) not supported at every cloud provider and 2)
where they are supported, they may not be free.
In testing I noticed that Mattermost clients appear to automatically load
custom RTC port config from the server anyway, so a 'weird' port like
3000whatever may not matter anyway b/c it's not a user-facing detail.
—
Reply to this email directly, view it on GitHub
<#384 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHROZVCB2CUNU542NZLZDTWLEA4TANCNFSM6AAAAAASJ753W4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I patched this but obv. this could be done more elegantly
The text was updated successfully, but these errors were encountered: