From bd0cccd56968c2fbd68564421ab88882290d5900 Mon Sep 17 00:00:00 2001 From: Angelos Kyratzakos Date: Mon, 29 Jan 2024 11:30:57 +0200 Subject: [PATCH] Fix SLO metric for soaking by adding `or vector(0)` (#28) --- internal/elrond/elrond_soak.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/elrond/elrond_soak.go b/internal/elrond/elrond_soak.go index 1647e48..75ebf56 100644 --- a/internal/elrond/elrond_soak.go +++ b/internal/elrond/elrond_soak.go @@ -48,7 +48,7 @@ func querySLOMetrics(ring *model.Ring, url string, queryTime time.Time, logger * defer cancel() var results []pmodel.Vector for _, installationGroup := range ring.InstallationGroups { - query := fmt.Sprintf("((slo:sli_error:ratio_rate5m{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate1h{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005))) or ignoring(slo_window)((slo:sli_error:ratio_rate30m{slo_service='%[1]s-ring-%[2]s'} > (6 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate6h{slo_service='%[1]s-ring-%[2]s'} > (3.3 * 0.005)))", installationGroup.Name, installationGroup.ProvisionerGroupID) + query := fmt.Sprintf("((slo:sli_error:ratio_rate5m{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate1h{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005))) or ignoring(slo_window)((slo:sli_error:ratio_rate30m{slo_service='%[1]s-ring-%[2]s'} > (6 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate6h{slo_service='%[1]s-ring-%[2]s'} > (3.3 * 0.005))) or vector(0)", installationGroup.Name, installationGroup.ProvisionerGroupID) result, warnings, err := v1api.Query(ctx, query, queryTime) if err != nil { return nil, errors.Wrap(err, "failed to query")