[MM-60201] Fixed a potential crash on removing server #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
approved these changes
Sep 21, 2024
pvev
approved these changes
Sep 23, 2024
devinbinnie
added
the
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wasn't able to reproduce the exact crash, other than this possible case where it's possible that the current server ID isn't set before the menu regenerates, causing a crash where the app menu might be re-rendered before the last server is removed. This PR just reverses those statements so that it's less likely that the
currentServerIdisn't set.Ticket Link
Closes #3122
https://mattermost.atlassian.net/browse/MM-60201