Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH 2874] Fix category for deb and clairfy directory information in README for linux #2884

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

BaumiCoder
Copy link
Contributor

@BaumiCoder BaumiCoder commented Oct 15, 2023

Summary

Fix the category for deb installation. The abnormal category for deb was been added with f4e2d91 by @Willyfrog. The changes in the commit seems to be not related with the category so it was probably a mistake to set the category for deb at this point.

And some changes to clarify where the directory of the application can be found.

I did not "execute" or test my changes in any way. I have no glue how to build such a electron application. I hope someone can check it before it will be merged.

And about the Unittest topic: Is it even possible to check such things in a Unittest

Ticket Link

Closes #2874

Checklist

Device Information

This PR was tested on:

Release Note

Set the category for the main menu correctly for installation with deb package.

The expliced category value for deb is not correct. The linux section
has a correct category value and deb is part of its target. So the
category from linux should be applied if there is no expliced one in the
deb section.
Issue: #2874
Change the example directory to the path, where it is at a deb
installation. Add a hint that a reader in a local README already
found the correct directory.
Issue: #2874
@mattermost-build
Copy link
Contributor

Hello @BaumiCoder,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@devinbinnie
Copy link
Member

/check-cla

1 similar comment
@BaumiCoder
Copy link
Contributor Author

/check-cla

Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @BaumiCoder!
Just tested and it looks like the app is showing under Internet on XFCE which is expected.

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Oct 16, 2023
@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 17, 2023
@devinbinnie devinbinnie merged commit 2ed96e9 into mattermost:master Oct 17, 2023
15 checks passed
@amyblais amyblais added this to the v5.6.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: README for linux is outdated OR Desktop launcher isn't created
6 participants