Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-53490] Reduce min window width to 600px #2787

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

devinbinnie
Copy link
Member

Summary

Dropping the minimum width of the Desktop App down to 600px to accommodate for users wanting to have the app in a smaller window.

Ticket Link

Closes #2786
https://mattermost.atlassian.net/browse/MM-53490

Set minimum window width to 600px

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core committer 1: UX Review Requires review by a UX Designer labels Jul 11, 2023
@devinbinnie devinbinnie added this to the v5.5.0 milestone Jul 11, 2023
@streamer45
Copy link
Contributor

Out of curiosity, wouldn't Mattermost render in "mobile view" at that point?

@devinbinnie
Copy link
Member Author

Out of curiosity, wouldn't Mattermost render in "mobile view" at that point?

Yes, but that still happens at 700px as well.

@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core committer label Jul 12, 2023
@duncan-bayne
Copy link

duncan-bayne commented Jul 12, 2023

Out of curiosity, wouldn't Mattermost render in "mobile view" at that point?

Yes, but that still happens at 700px as well.

As the originator of this request, that's fine with me :). I use a tiling window manager, so apps that set a minimum size (which seems to be most Electron apps?) break my desktop.

Very happy for the app to switch to mobile view if that makes sense, I just want to be able to resize it the way I want :).

Thanks for looking at this issue so promptly.

@streamer45
Copy link
Contributor

Out of curiosity, wouldn't Mattermost render in "mobile view" at that point?

Yes, but that still happens at 700px as well.

As the originator of this request, that's fine with me :). I use a tiling window manager, so apps that set a minimum size (which seems to be most Electron apps?) break my desktop.

Very happy for the app to switch to mobile view if that makes sense, I just want to be able to resize it the way I want :).

Thanks for looking at this issue so promptly.

Interesting, I am an i3wm user and can resize at will. But probably because the window manager ignores anything the app says :p

@duncan-bayne
Copy link

duncan-bayne commented Jul 12, 2023

@streamer45 I normally use StumpWM, and it's the same - StumpWM does what StumpWM wants :)

The minimum size thing hits me on macOS. I'm having the same problem with Spotify, FWIW. The OS won't let the "WM" (Rectangle) override the app's specified minimum size.

Personal opinion: apps shouldn't have opinions on their geometry limits, let alone be able to enforce them over the user's instructions.

@streamer45
Copy link
Contributor

That makes sense, thanks for the context!

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 1: UX Review Requires review by a UX Designer labels Jul 18, 2023
@devinbinnie devinbinnie merged commit d4a4def into mattermost:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App can't be resized to 1/3 screen width
6 participants