Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore windows ci failure #2770

Merged
merged 10 commits into from
Jun 26, 2023
Merged

explore windows ci failure #2770

merged 10 commits into from
Jun 26, 2023

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Jun 22, 2023

observed that node-gyp was not globally available and having error when installing a package @electron/notorize (link) in windows-install-deps and it was causing even build-win-no-installer job to fail/not trigger.

NONE

@yasserfaraazkhan yasserfaraazkhan changed the title Update settings.test.js explore windows ci failure Jun 22, 2023
@yasserfaraazkhan
Copy link
Contributor Author

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered e2e desktop testing!
https://git.internal.mattermost.com/qa/desktop-e2e-testing/-/pipelines/347214

@devinbinnie devinbinnie merged commit 3f352a6 into master Jun 26, 2023
@devinbinnie devinbinnie deleted the yasserfaraazkhan-patch-1 branch June 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants