Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(da-clients): add secrets #2954

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(da-clients): add secrets #2954

wants to merge 9 commits into from

Conversation

dimazhornyk
Copy link
Contributor

@dimazhornyk dimazhornyk commented Sep 24, 2024 •
edited
Loading

What ❔

Add an opportunity to store the sensitive information of DA clients in the secrets.

Why ❔

Some sensitive info is currently stored as plaintext, which is not secure, we should use secrets for those values

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@dimazhornyk dimazhornyk marked this pull request as ready for review September 25, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo approved these changes

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimazhornyk @Deniallugo