Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ethers v5 #156

Merged
merged 1 commit into from
Aug 2, 2024
Merged

chore: remove ethers v5 #156

merged 1 commit into from
Aug 2, 2024

Conversation

jennyg0
Copy link
Contributor

@jennyg0 jennyg0 commented Jul 29, 2024

What πŸ’»

  • removes ethers v5 from commands

Why βœ‹

  • no longer supporting v5

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes πŸ“

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@jennyg0 jennyg0 requested a review from a team as a code owner July 29, 2024 16:08
@JackHamer09
Copy link
Member

No strong opinion to not remove it, but most of our tools still use v5 😁

@JackHamer09
Copy link
Member

JackHamer09 commented Jul 30, 2024

I'm in favor in moving to viem instead of upgrading to v6. Most of the industry is abandoning ethers because a lot of things are so much better in viem, including proper TS typings.

@itsacoyote
Copy link
Contributor

No strong opinion to not remove it, but most of our tools still use v5 😁

We can still maintain those projects, but probably a good idea to no longer support making new projects with v5?
As for viem, I think it would be a good switch, we can look into setting up a template for that.

@JackHamer09
Copy link
Member

@itsacoyote We already have viem templates but they are pretty outdated. They still use v1 viem but there was major update a while ago. Tho shouldn't be many changes for them templates

@itsacoyote itsacoyote merged commit 7aed822 into main Aug 2, 2024
2 checks passed
@itsacoyote itsacoyote deleted the rm-ethers-v5 branch August 2, 2024 17:16
Copy link

πŸŽ‰ This PR is included in version 1.8.3 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants