-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: EVM emulator #825
Draft
0xVolosnikov
wants to merge
75
commits into
dev
Choose a base branch
from
integration-stable/evm-emulator
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: EVM emulator #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert fetch deployed code len optimization * Calculate hashes:fix
* Optimize EvmGasManager * Fix typo * Simplify consumeEvmFrame * Update hashes
* Remove invalid todos adding overflow checks * Remove old memory check * Add preprocessed evm interpreter * Remove unnecesary memory checks * Update hash for evm interpreter
* Revert consumeEvmFrame EvmGasManager optimization * Update hashes
* Cleanup EvmInterpreterFunctions * Cleanup in logs * Remove unneded changes * Use rawMimicCall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are:
EvmGasManager.sol
andEvmInterpreter.yul
contracts were added.yarn sc preprocess:interpreter
command to preprocess the interpreter from its three template files (EvmInterpreterFunctions.template.yul
,EvmInterpereterLoop.template.yul
andEvmInterpreter.template.yul
)CodeOracle
was updated to handle decommitments of EVM contracts (i.e. the case where theversion
byte of the code hash is2
).execute
method of the DefaultAccount now checks the second byte to see if the constructor is being called and dispatches it to thecreateEVM
method on the deployer if so.ContractDeployer
has a few more methods required for equivalence:setDeployedCode
, used by the interpreter to publish evm bytecodes and store code hashescreateEVMInternal
and internal functions it calls, used by the interpreter forCREATE
opcodesContractDeployer
also now maintains anevmCodeHash
mapping of EVM code hashes.AccountCodeStorage
now checks for EVM contracts ongetCodeHash
and queries the mapping above if so.0
) that thereserved1
byte should be zero was removed, as it now corresponds to evm contracts.Moved from: #821