Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add foundry to ci #815

Merged
merged 18 commits into from
Sep 17, 2024
Merged

Conversation

Deniallugo
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
@Deniallugo Deniallugo changed the base branch from deniallugo-zk-toolbox-dev to release-v25-protocol-defense September 17, 2024 14:46
@Deniallugo Deniallugo changed the base branch from release-v25-protocol-defense to deniallugo-zk-toolbox-dev September 17, 2024 14:54
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
Copy link

Coverage after merging otani-add-foundry-to-ci into deniallugo-zk-toolbox-dev will be

86.09%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/bridge
   L1ERC20Bridge.sol81.63%80%75%83.87%62, 70, 70, 70–71, 73–74
   L1SharedBridge.sol84.40%90.77%81.58%81.17%102, 110, 118, 125, 125, 125–126, 145–149, 191, 200, 213, 216, 227, 227, 227–231, 231, 231–232, 234, 239–241, 241, 241–242, 244–246, 246, 246–247, 249, 261, 270, 270, 270–271, 445, 448, 580, 597, 608, 624, 721, 962, 967
contracts/bridgehub
   Bridgehub.sol95.09%100%100%91.49%101, 113, 133, 156, 159, 333, 49, 64
contracts/common
   ReentrancyGuard.sol95.65%100%100%92.86%79
contracts/common/libraries
   L2ContractHelper.sol54.55%60%50%52.63%26, 32, 36, 50, 52, 52, 52–53, 57, 57, 57–58, 66
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   ChainAdmin.sol0%0%0%0%27, 27, 27–28, 30, 32–33, 39–40, 47–48, 56, 56, 56–57, 60, 62–63, 63, 63, 66, 69, 78, 78, 78–79, 81
   Governance.sol91.74%93.75%95%89.86%44, 44, 44–45, 48, 50–51, 53–54
contracts/state-transition
   StateTransitionManager.sol63.80%75%50%65.42%101, 106–110, 116, 150, 153, 156, 159, 201, 203–204, 209, 211, 211, 211–212, 215–217, 219–220, 255, 275, 289, 294, 299, 304, 309, 314, 319, 386, 386, 386–387, 390, 456, 92, 92, 92–93
   TestnetVerifier.sol50%50%50%50%16, 28, 32
   ValidatorTimelock.sol92.41%100%94.74%89.58%241, 59–61, 83
   Verifier.sol91.21%92.86%96.30%90.93%1674, 287–302, 305–308, 311–318, 321–328, 331–332, 335–336, 339, 385, 396, 407, 418, 429, 445, 454, 454–455, 905
contracts/state-transition/chain-deps
   DiamondInit.sol91.07%100%100%86.11%35, 38, 41, 44, 47
   DiamondProxy.sol84.62%75%100%88.24%16, 16, 16–17
contracts/state-transition/chain-deps/facets
   Admin.sol86.73%81.82%92.31%87.30%109, 109, 109–110, 112–113, 142, 175, 178, 180, 84, 95
   Executor.sol88.67%90.58%84.38%88.16%138, 192, 197, 202, 207, 212, 217, 222, 227, 231, 236, 240, 242, 245, 247, 261, 280, 295, 362, 425, 448–449, 469, 49, 520, 529, 549, 557, 57, 59, 59, 59–60, 62, 620, 63, 647, 697, 701, 71, 75, 775
   Getters.sol92.23%100%90.24%93.10%153, 206, 72, 77
   Mailbox.sol100%100%100%100%
   ZkSyncHyperchainBase.sol97.14%100%100%92.86%56
contracts/state-transition/libraries
   Diamond.sol94.12%88.64%100%95.96%110, 113, 115, 117, 120, 199, 308, 311, 316
   LibMap.sol100%100%100%100%
   Merkle.sol100%100%100%100%
   PriorityQueue.sol100%100%100%100%
   TransactionValidator.sol97.73%100%100%95.92%67, 70
contracts/upgrades
   BaseZkSyncUpgrade.sol72.03%86.36%100%60.92%104, 104, 104–105, 108, 111, 114–115, 126, 126, 126–127, 130, 133, 136–137, 151–153, 171–173, 213, 216, 233, 250, 253, 258–259, 259, 259–260, 272, 279, 286, 294, 299, 309, 312, 76
   BaseZkSyncUpgradeGenesis.sol83.33%100%100%71.43%26, 34, 41, 53, 63, 66
   DefaultUpgrade.sol100%100%100%100%
   GenesisUpgrade.sol100%100%100%100%
contracts/vendor
   AddressAliasHelper.sol100%100%100%100%

@Deniallugo Deniallugo merged commit f3178f7 into deniallugo-zk-toolbox-dev Sep 17, 2024
17 of 19 checks passed
@Deniallugo Deniallugo deleted the otani-add-foundry-to-ci branch September 17, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants