Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM-Equivalence-YUL] Optimize EvmGasManager #734

Closed
wants to merge 10 commits into from

Conversation

0xVolosnikov
Copy link

@0xVolosnikov 0xVolosnikov commented Aug 22, 2024

What ❔

Results so far:

╠═╡ Ergs/gas (-%) ╞═╡ EVMInterpreter M3B3 ╞═╣
║ SHA3                               -0.220 ║
║ BALANCE                            44.061 ║
║ EXTCODESIZE                        24.503 ║
║ EXTCODECOPY                        24.169 ║
║ EXTCODEHASH                        19.522 ║
║ SELFBALANCE                        -0.058 ║
║ SLOAD                              19.776 ║
║ SSTORE                             47.163 ║
║ CALL                                2.204 ║
║ STATICCALL                          2.205 ║
║ DELEGATECALL                        4.040 ║
║ CREATE                              0.979 ║
║ CREATE2                             1.028 ║
╚═══════════════════════════════════════════╝

Using transient storage for evm callstack frames improves the result by -30% for calls/delegatecalls/staticcalls, but requires changes in testing tools, I will put this in a separate PR.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@0xVolosnikov
Copy link
Author

I think that the benchmarks are not representative here, since they apparently do not take into account refunds for warm slots in the storage (the storage implementation in the test VM does not contain refunds)

@0xVolosnikov 0xVolosnikov marked this pull request as draft August 23, 2024 10:20
@0xVolosnikov 0xVolosnikov marked this pull request as draft August 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant