From 82fef7c5764e60886e306874cba0238613a00f9e Mon Sep 17 00:00:00 2001 From: Raid Ateir Date: Mon, 11 Nov 2024 20:56:01 +0700 Subject: [PATCH] (fix): wrong function marked internal --- l1-contracts/contracts/governance/PermanentRestriction.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/l1-contracts/contracts/governance/PermanentRestriction.sol b/l1-contracts/contracts/governance/PermanentRestriction.sol index 963f252f1..96792f19e 100644 --- a/l1-contracts/contracts/governance/PermanentRestriction.sol +++ b/l1-contracts/contracts/governance/PermanentRestriction.sol @@ -242,13 +242,12 @@ contract PermanentRestriction is Restriction, IPermanentRestriction, Ownable2Ste } /// @notice Tries to call `IGetters.getChainId()` function on the `_chain`. - /// @notice Function is internal for testing purposes only. /// It ensures that the returndata is of correct format and if not, it returns false. /// @param _chain The address of the potential chain /// @return chainId The chainId of the chain. /// @return success Whether the call was successful. /// If the second item is `false`, the caller should ignore the first value. - function _getChainIdUnffallibleCall(address _chain) internal view returns (uint256 chainId, bool success) { + function _getChainIdUnffallibleCall(address _chain) private view returns (uint256 chainId, bool success) { bytes4 selector = IGetters.getChainId.selector; // Note, that we do use assembly here to ensure that the function does not panic in case of @@ -272,6 +271,7 @@ contract PermanentRestriction is Restriction, IPermanentRestriction, Ownable2Ste } /// @notice Tries to get the new admin from the migration. + /// @notice Function is internal for testing purposes only. /// @param _call The call data. /// @return Returns a tuple of the new admin and whether the transaction is indeed the migration. /// If the second item is `false`, the caller should ignore the first value.