From 6d71de4a7696d83d3efdd968f90613bce252b240 Mon Sep 17 00:00:00 2001 From: vladbochok Date: Tue, 7 May 2024 16:06:07 +0100 Subject: [PATCH] Fix --- .github/workflows/l1-contracts-ci.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/l1-contracts-ci.yaml b/.github/workflows/l1-contracts-ci.yaml index 71bc0381f..0f8e5ea3d 100644 --- a/.github/workflows/l1-contracts-ci.yaml +++ b/.github/workflows/l1-contracts-ci.yaml @@ -147,6 +147,9 @@ jobs: run: diff tools/data/Verifier.sol l1-contracts/contracts/state-transition/Verifier.sol coverage: + defaults: + run: + working-directory: l1-contracts needs: [build, lint] runs-on: ubuntu-latest @@ -179,7 +182,7 @@ jobs: l1-contracts/typechain - name: Run coverage - run: FOUNDRY_PROFILE=default yarn l1 test:foundry && FOUNDRY_PROFILE=default yarn l1 coverage:foundry --report summary --report lcov + run: FOUNDRY_PROFILE=default yarn test:foundry && FOUNDRY_PROFILE=default yarn coverage:foundry --report summary --report lcov # To ignore coverage for certain directories modify the paths in this step as needed. The # below default ignores coverage results for the test and script directories. Alternatively, @@ -189,7 +192,6 @@ jobs: # The `--rc lcov_branch_coverage=1` part keeps branch info in the filtered report, since lcov # defaults to removing branch info. - name: Filter directories - working-directory: l1-contracts run: | sudo apt update && sudo apt install -y lcov lcov --remove lcov.info 'l1-contracts/test/*' 'l1-contracts/contracts/dev-contracts/*' 'l1-contracts/lib/*' --output-file lcov.info --rc lcov_branch_coverage=1 @@ -204,11 +206,11 @@ jobs: uses: romeovs/lcov-reporter-action@v0.3.1 with: delete-old-comments: true - lcov-file: ./l1-contracts/lcov.info + lcov-file: ./lcov.info github-token: ${{ secrets.GITHUB_TOKEN }} # Adds a coverage summary comment to the PR. - name: Verify minimum coverage uses: zgosalvez/github-actions-report-lcov@v2 with: - coverage-files: ./l1-contracts/lcov.info + coverage-files: ./lcov.info minimum-coverage: 80 # Set coverage threshold.