Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast validators signature and collect QC (BFT-414) #76

Merged
merged 88 commits into from
May 21, 2024
Merged

Broadcast validators signature and collect QC (BFT-414) #76

merged 88 commits into from
May 21, 2024

Commits on Mar 14, 2024

  1. Create new message type for validators to broadcast signature

    @IAvecilla
    IAvecilla committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    23ef076 View commit details
    Browse the repository at this point in the history

  2. Add new message to send to the gossip network

    @IAvecilla
    IAvecilla committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    93732c4 View commit details
    Browse the repository at this point in the history

  3. Add protobuf related functions for new message

    @IAvecilla
    IAvecilla committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cbc7790 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Update batch signature message

    @IAvecilla
    IAvecilla committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a942623 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Add new rpc clients for validators to receive signatures

    @IAvecilla
    IAvecilla committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    73122a5 View commit details
    Browse the repository at this point in the history

  2. Add new input message for network actor

    @IAvecilla
    IAvecilla committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1538d0a View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Update L1Batch message variant

    @IAvecilla
    IAvecilla committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    11680fd View commit details
    Browse the repository at this point in the history

  2. Add verification for L1 Batcj signatures

    @IAvecilla
    IAvecilla committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    94f5b67 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a532bbc View commit details
    Browse the repository at this point in the history

  4. Update network struct for l1 batches rpc

    @IAvecilla
    IAvecilla committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    cec46c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. introduced msg pool

    @pompon0
    pompon0 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5c2639b View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. retransmission

    @pompon0
    pompon0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5926692 View commit details
    Browse the repository at this point in the history

  2. typo

    @pompon0
    pompon0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    36be3da View commit details
    Browse the repository at this point in the history

  3. retransmission test

    @pompon0
    pompon0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1b28fd7 View commit details
    Browse the repository at this point in the history

  4. added tests

    @pompon0
    pompon0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c8d06ef View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. removed limiting from sync_blocks

    @pompon0
    pompon0 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    96be90b View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @pompon0
    pompon0 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    16693df View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @pompon0
    pompon0 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c9935c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c670006 View commit details
    Browse the repository at this point in the history

  2. Fix clippy lints

    @IAvecilla
    IAvecilla committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    96a50de View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Added support for persisting blocks in parallel (#98) 

    Statekeeper is storing blocks to postgres in parallel to processing next
blocks. Our simplified API so far required persisting one block to
finish before processing the next block. This effectively disabled the
parallelization in statekeeper and therefore the EN with consensus
enabled was significantly slower than EN without consensus. This PR
updates the api to allow persisting multiple blocks in parallel. Long
term this change most likely won't be that useful, because statekeeper
of a validator node will have to work synchronously with consensus (but
that requires improving statekeeper anyway).

I've also implemented caching inmemory the most recent blocks (even if
they got persisted) to address the inefficiency found during the
loadtest.
    @pompon0
    pompon0 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1dcda70 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fb64951 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. New attester role for full nodes (#93) 

    ## What ❔

This PR introduces a new role called `attester`.

## Why ❔

This role will handle various keys and messages associated with L1
batches. In the future, this will enable the use of a new signature
scheme specifically for L1 batch signatures, distinguishing them from
the block signatures of validators.

---------

Co-authored-by: Ignacio Avecilla <[email protected]>
    @IAvecilla
    IAvecilla and Ignacio Avecilla committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d7069f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Rewritten sync_blocks actor to maximize utilization. (#101) 

    Previous implementation severely limited the total throughput.

---------

Co-authored-by: Bruno França <[email protected]>
    @pompon0 @brunoffranca
    pompon0 and brunoffranca committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8d76509 View commit details
    Browse the repository at this point in the history

  2. Weighted attesters (#102) 

    ## What ❔

Add weights to the attester just like we do with the validators.

## Why ❔

To be able to give our node more importance than the other nodes,
producing and finalizing blocks only if they are signed by our node.
    @IAvecilla
    IAvecilla committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    26488ec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f729182 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'version0' into signature_broadcast

    @IAvecilla
    IAvecilla committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    32fc525 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4d2675c View commit details
    Browse the repository at this point in the history

  2. l1 batch signature watcher for nodes in the gossip net

    @IAvecilla
    IAvecilla committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4e32fc0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. New push signature request for full nodes in the gossip network

    @IAvecilla
    IAvecilla committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7c1ab8a View commit details
    Browse the repository at this point in the history

  2. Update gossip proto file

    @IAvecilla
    IAvecilla committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dd912d1 View commit details
    Browse the repository at this point in the history

  3. Add push signature watcher to the runner of the gossip network

    @IAvecilla
    IAvecilla committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    182adca View commit details
    Browse the repository at this point in the history

  4. Fix lints

    @IAvecilla
    IAvecilla committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d6a5f80 View commit details
    Browse the repository at this point in the history

  5. Add attester key to the config

    @IAvecilla
    IAvecilla committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1359e54 View commit details
    Browse the repository at this point in the history

  6. Identify node in gossip network adding the attester key

    @IAvecilla
    IAvecilla committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1e4e720 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Update watcher and signature broadcasting tasks

    @IAvecilla
    IAvecilla committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5f5cee1 View commit details
    Browse the repository at this point in the history

  2. Add tests and update test setup to get batches

    @IAvecilla
    IAvecilla committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e9ad0fa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b53ec80 View commit details
    Browse the repository at this point in the history

  4. Fix genesis hash test

    @IAvecilla
    IAvecilla committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8365c9f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Fix encoding tests and hash back to previous version

    @IAvecilla
    IAvecilla committed May 6, 2024
    Configuration menu
    Copy the full SHA
    05f80e2 View commit details
    Browse the repository at this point in the history

  2. Fix deny

    @IAvecilla
    IAvecilla committed May 6, 2024
    Configuration menu
    Copy the full SHA
    df7b777 View commit details
    Browse the repository at this point in the history

  3. Add test disclaimer

    @IAvecilla
    IAvecilla committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e77db65 View commit details
    Browse the repository at this point in the history

  4. Update qc construction implementation

    @IAvecilla
    IAvecilla committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e86aa92 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Delete committee prefix for validators and attesters in genesis

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9511247 View commit details
    Browse the repository at this point in the history

  2. Fix some crate imports

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4f548d7 View commit details
    Browse the repository at this point in the history

  3. Update limit rate for rpc requests with batch signatures

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5cf4fae View commit details
    Browse the repository at this point in the history

  4. Update name for signed messages in proto file

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    03780cb View commit details
    Browse the repository at this point in the history

  5. Update attester field in genesis for proto struct

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5392a1c View commit details
    Browse the repository at this point in the history

  6. Leave TODO comment for hash of the L1 Batch

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e0f16de View commit details
    Browse the repository at this point in the history

  7. Update proto genesis struct

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    073c22d View commit details
    Browse the repository at this point in the history

  8. Delete unused code related to attesters an l1 batches

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    93b59be View commit details
    Browse the repository at this point in the history

  9. Use qualified names for attester imports

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a9b5a5a View commit details
    Browse the repository at this point in the history

  10. Renamed most of batch related structs for consistency

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5c0e7b7 View commit details
    Browse the repository at this point in the history

  11. Fix some function names

    @IAvecilla
    IAvecilla committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0271e43 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Implement hash for every curve signature and derive it for each role

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ecb3c99 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect docs for attesters

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2201c54 View commit details
    Browse the repository at this point in the history

  3. Update encoding tests for secret keys

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    99c9302 View commit details
    Browse the repository at this point in the history

  4. Make batch qc adding function return proper errors

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e09b6f6 View commit details
    Browse the repository at this point in the history

  5. Remove timestamp for batch message

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    76a0a9b View commit details
    Browse the repository at this point in the history

  6. Update rpc method name for push batch votes

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d4acad5 View commit details
    Browse the repository at this point in the history

  7. Calculate correctly the expected weight for tests

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b50fb48 View commit details
    Browse the repository at this point in the history

  8. Fix format and clippy lints

    @IAvecilla
    IAvecilla committed May 8, 2024
    Configuration menu
    Copy the full SHA
    0aa2131 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Add trait for the state keeper

    @IAvecilla
    IAvecilla committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8168af7 View commit details
    Browse the repository at this point in the history

  2. Use calculated QC by the node instead of taking it from signers

    @IAvecilla
    IAvecilla committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f380e74 View commit details
    Browse the repository at this point in the history

  3. Add extra comments on QC updater

    @IAvecilla
    IAvecilla committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c9f6152 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Panic if overflow happens for batch number

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    eabc7d7 View commit details
    Browse the repository at this point in the history

  2. Use validator function for max faulty weight

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e163378 View commit details
    Browse the repository at this point in the history

  3. Use batch votes instead of batch signatures

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    246d834 View commit details
    Browse the repository at this point in the history

  4. Update some names referring to signatures changing it to votes

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2d331ef View commit details
    Browse the repository at this point in the history

  5. Move trait to persist batches to the storage workspace

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7eee7dc View commit details
    Browse the repository at this point in the history

  6. Implement deref for committees

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    fab01d5 View commit details
    Browse the repository at this point in the history

  7. Use map instead of and_then

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c6fe4db View commit details
    Browse the repository at this point in the history

  8. Fix clippy

    @IAvecilla
    IAvecilla committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3cec7be View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b6721a8 View commit details
    Browse the repository at this point in the history

  2. Fix some unused imports

    @IAvecilla
    IAvecilla committed May 14, 2024
    Configuration menu
    Copy the full SHA
    55feb75 View commit details
    Browse the repository at this point in the history

  3. Make attesters field in genesis optional

    @IAvecilla
    IAvecilla committed May 14, 2024
    Configuration menu
    Copy the full SHA
    70d8c91 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Optional build and read protobuff for attester committee

    @IAvecilla
    IAvecilla committed May 15, 2024
    Configuration menu
    Copy the full SHA
    13b63d9 View commit details
    Browse the repository at this point in the history

  2. Fix clippy lint

    @IAvecilla
    IAvecilla committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d521f10 View commit details
    Browse the repository at this point in the history

  3. Delete attester key from the config

    @IAvecilla
    IAvecilla committed May 15, 2024
    Configuration menu
    Copy the full SHA
    520e412 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Generate valid genesis to verify in test

    @IAvecilla
    IAvecilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ef5c654 View commit details
    Browse the repository at this point in the history

  2. Fix clippy lints with latest rust version

    @IAvecilla
    IAvecilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    034f196 View commit details
    Browse the repository at this point in the history

  3. Fix genesis raw encoding for empty attesters

    @IAvecilla
    IAvecilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    77e45d6 View commit details
    Browse the repository at this point in the history

  4. Fix latest comments

    @IAvecilla
    IAvecilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    834f0fb View commit details
    Browse the repository at this point in the history

  5. Get attester at the beginning of the tests

    @IAvecilla
    IAvecilla committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5f35266 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Fix some last comments

    @IAvecilla
    IAvecilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d2c8233 View commit details
    Browse the repository at this point in the history

  2. Fix CI protobuff job

    @IAvecilla
    IAvecilla committed May 17, 2024
    Configuration menu
    Copy the full SHA
    672046f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Fix last comment in gossip runner

    @IAvecilla
    IAvecilla committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d84421c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into signature_broadcast

    @IAvecilla
    IAvecilla committed May 20, 2024
    Configuration menu
    Copy the full SHA
    06e1350 View commit details
    Browse the repository at this point in the history