Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced plain json with structs in Namespace and Deployment definition (BFT-430) #68

Merged
merged 106 commits into from
Feb 28, 2024
Merged

Replaced plain json with structs in Namespace and Deployment definition (BFT-430) #68

merged 106 commits into from
Feb 28, 2024

Conversation

ElFantasma
Copy link
Contributor

What ❔

Improves code quality replacing json defined structures by k8s_openapistructs

Why ❔

A comment in PR #62 suggested to use rust types instead of json strings to declare k8s structures.
In order to get that PR merged I created a new sub-issue and this PR solves it

IAvecilla and others added 30 commits January 10, 2024 18:34
@IAvecilla
Add dockerfile for executable node
6bd6170
@IAvecilla
Add compose file for testing purposes
b2fb9ab
@IAvecilla
Add entrypoint for node consensus dockerfile
e768bc6
@IAvecilla
Add some comments and improve compose test file
e6b6487
@IAvecilla
Add new makefile commands to run dockerized consensus node
4ca7fdc
@IAvecilla
Update readme with docs to run consensus node in docker
28df58b
@IAvecilla
Delete unnecesary building dependency in compose file
3e4b881
@IAvecilla
Rename docker image
febcafc
@IAvecilla
Set container names manually in compose file
b2e7e9c
@IAvecilla
Separate config directory for nodes running in docker
5e27e6e
@IAvecilla
Fix node configuration for docker consensus example
6e2236a
@IAvecilla
Improve command to run a node in a container
810a4b5
@IAvecilla
Generate the node configs in release mode
4088c0a
@IAvecilla
Fix docker cleanup to force deletion
4475489
@IAvecilla
Remove unnecesary copies to container
689b6d5
@IAvecilla
Add target dir to docker ignore
99dc691
@IAvecilla
Move every docker related config file to the project root
a3b270d
@IAvecilla @brunoffranca
Fix typo in README
f93890f 
Co-authored-by: Bruno França <[email protected]>
@IAvecilla
Fix typo in makefile command
f3893cf
@IAvecilla
Make the path to makefile be the same for local and docker
1c721c8
@pompon0
disabled clipply lint
8cac863
@pompon0
fixed lint, updated deps
d24c8bc
@IAvecilla
Change file name for the docker entrypoint and add comment to the script
9520c4c
@IAvecilla
Move version to latest for rust image
54c72ce
@IAvecilla
Change name of command and dir generation for node config
13e61e1
@IAvecilla
Add command to stop dockerized nodes
3b8d299
@IAvecilla
Add example file with local address for node configuration
2d09c1d
@IAvecilla
Update README with new updates
c287c56
@IAvecilla
Write a general overview on the README
e66cec9
@IAvecilla
Add tonic as dependency
eb7077e
ElFantasma and others added 23 commits February 1, 2024 19:52
@ElFantasma
Added k8s module
44c979e
@IAvecilla
Add old crate versions to deny.toml file
5257592
@IAvecilla
Use new app config api for test in tools crate
75cd2cf
@IAvecilla
Merge branch 'rpc_test_layer' into k8s_deploy_script
958954f
@ElFantasma
Deploying seed peers in a different phase
b0803dc
@ElFantasma
Retrieving seed peers IPs and using it in the rest of the peers
3a249dc
@ElFantasma
Busy waiting for pods to start to obtain their IPs
d612889
@IAvecilla
Revert change to have node ips as directory names for local config
6bd5394
@ElFantasma
Making cli argument optional and forwarding arguments in entrypoint s…
1d58431 
…cript
@ElFantasma
Merge branch 'main' into k8s_deploy_script
960ff13
@ElFantasma
Fixed compiler warnings
c864f51
@ElFantasma
Consensus node now can obtain it's public address from an ENV VAR. Al…
b5b5ee6 
…so added a endpoint to be able to check config from nodes
@ElFantasma
Added config RPC endpoint
702a587
@ElFantasma
Corrected k8s_entrypoint.sh script to forward cli arguments
1ef6877
@ElFantasma
Several corrections on naming and coding style
5e8b011
@ElFantasma
Fixed deny.toml for kube.rs
c62f0b4
@ElFantasma
Fixed clippy suggestions
2e89af8
@ElFantasma
Added amount of seed nodes as cli argument
fb0c345
@ElFantasma
Merge branch 'main' into k8s_deploy_script
3b1256f
@ElFantasma
Added brief description for k8s deployment in README.md
23a7761
@ElFantasma
Unified node_name and node_id values
7dbf270
@ElFantasma
Replaced plain json with k8s_openapi structs in Namespace and Deploym…
336a28b 
…ent definition
@ElFantasma
Fixed clippy suggestions
8ec4af5
Base automatically changed from k8s_deploy_script to main February 27, 2024 13:19
@brunoffranca brunoffranca changed the title Replaced plain json with structs in Namespace and Deployment definition Replaced plain json with structs in Namespace and Deployment definition (BFT-430) Feb 28, 2024
@brunoffranca brunoffranca merged commit 5136953 into main Feb 28, 2024
4 checks passed
@brunoffranca brunoffranca deleted the replace_json_k8s branch February 28, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

@brunoffranca brunoffranca brunoffranca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElFantasma @pompon0 @brunoffranca @IAvecilla