Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made max_payload_size configurable #60

Merged
merged 24 commits into from
Jan 24, 2024
Merged

made max_payload_size configurable #60

merged 24 commits into from
Jan 24, 2024

Conversation

pompon0
Copy link
Collaborator

@pompon0 pompon0 commented Jan 22, 2024

The max_payload_size is checked in bft replica and also implies buffering limits in the network actor (both gossip and consensus networks). It turned out that hardcoding it was too optimistic strategy, so I've extracted it to a config, so that it is settable in runtime. Given the lesson learned, I'll be also deprecating the ProtoFmt::max_size() function soon.
Additional changes:

  • added some logging useful for debugging the zksync-era tests and improved existing logging to always show error the cause, not just the leaf message.
  • removed tracing::instrument annotations which were logging non-critical/not-a-bug errors on level ERROR
  • made network crate depend on the storage crate to avoid the workaround way of implementing the get_block rpc
  • cleaned up the implementations of the rpcs to be more consistent
  • deduplicated the testonly helpers and moved them to the crates that they belong to

Copy link
Member

@brunoffranca brunoffranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always. No notes.

@pompon0 pompon0 merged commit 5b3d383 into main Jan 24, 2024
3 of 4 checks passed
@pompon0 pompon0 deleted the gprusak-ord-for-key branch January 24, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants