Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put full hash into Cargo.toml for deps #50

Merged
merged 2 commits into from
Dec 12, 2023
Merged

put full hash into Cargo.toml for deps #50

merged 2 commits into from
Dec 12, 2023

Conversation

pompon0
Copy link
Collaborator

@pompon0 pompon0 commented Dec 12, 2023

What ❔

Put full hash into Cargo.toml for deps.

Why ❔

cargo is not smart enough to deduplicate deps specified by different lengths of the hash prefixes. It is particularly bad for vise which specifies global variables and therefore metrics get registered to different locations.

@pompon0 pompon0 merged commit 49b1a98 into main Dec 12, 2023
4 checks passed
@pompon0 pompon0 deleted the gprusak-full-hash branch December 12, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants