Add liveness tests (BFT-387) #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
reviewed
Dec 4, 2023
pompon0
reviewed
Dec 4, 2023
pompon0
reviewed
Dec 5, 2023
pompon0
reviewed
Dec 5, 2023
|
fyi, all these |
pompon0
reviewed
Dec 6, 2023
pompon0
reviewed
Dec 6, 2023
| @@ -83,8 +135,8 @@ impl UTHarness { | |||
| &self.consensus.inner.secret_key | |||
| } | |||
|
|
|||
| pub(crate) fn owner_as_view_leader(&self) -> ViewNumber { | |||
| let mut view = self.current_replica_view(); | |||
| pub(crate) fn owner_as_view_leader_next(&self) -> ViewNumber { | |||
There was a problem hiding this comment.
nit: IMO the "next" suffix seems to suggest at the very least that the returned view will be AFTER the current view.
There was a problem hiding this comment.
I wanted to imply that it's not beyond the next one.
But perhaps there will be a use case where the current is to be skipped, so I made it explicit with a longer name: owner_as_view_leader_current_or_next.
pompon0
approved these changes
Dec 6, 2023
brunoffranca
approved these changes
Dec 6, 2023
moshababo
force-pushed
the
liveness_tests
branch
from
9ac1ffd
to
9c75462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new protocol liveness tests for when the network becomes idle in various stages:
timeout_leader_no_prepares- when leader have no cached prepare messages for the current viewtimeout_leader_some_prepares- when leader have some cached prepare messages for the current viewtimeout_leader_in_commit- when leader is in commit phasetimeout_replica_in_commit- when replica is in commit phasetimeout_leader_some_commits- when leader have some cached commit messages for the current viewtimeout_leader_in_consecutive_prepare- when leader is in a consecutive prepare phase