Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Cranky and started using Cargo's lints table #37

Merged
merged 11 commits into from
Dec 6, 2023
Merged

Conversation

brunoffranca
Copy link
Member

What ❔

Removes the Cranky tool and moves all existing lints to the workspace's Cargo.toml.

Why ❔

Lint configuration through Cargo was just stabilized in Rust, so we no longer need a third-party tool for it.

node/Cargo.toml Outdated Show resolved Hide resolved
node/Cargo.toml Show resolved Hide resolved
node/libs/concurrency/Cargo.toml Outdated Show resolved Hide resolved
@pompon0
Copy link
Collaborator

pompon0 commented Nov 27, 2023

The lint that is failing CI seems to be false positive. Please disable the corresponding linting rule.

@slowli
Copy link
Contributor

slowli commented Nov 27, 2023

@pompon0 The relevant rule (redundant_locals) is disabled; I think the problem is that the default Rust version included into the GitHub runner ATM is 1.73, which doesn't understand the lint section in workspace / crate manifests. We'd probably need to have a separate step installing Rust.

@brunoffranca
Copy link
Member Author

The Github runner is still running Rust 1.73. We just need to wait until they bump the new version. No need to change anything else.

@brunoffranca brunoffranca merged commit aa5c0dc into main Dec 6, 2023
4 checks passed
@brunoffranca brunoffranca deleted the bruno-lints branch December 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants