refactor: made TLS certificate optional for the debug page #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
changed the title
|
Is it worth it to still keep the option of making the debug page public, or should we just force it to be local and then we can remove the whole TLS cert code? |
|
I think it would be good to be able to inspect debug page of the partner's EN in case they have problems. |
brunoffranca
approved these changes
Sep 23, 2024
|
I doubt that will get used. The debug page doesn't even have that much information, and partners can also just let us connect via SSH. But the functionality is already here anyway. |
brunoffranca
added
release-please:force-run
and removed
release-please:force-run
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.