chore: Remove deprecated cargo deny fields #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
changed the title
aakoshh
changed the title
|
Done in #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Follow up for #171
Removes fields which are deprecated according to https://github.com/matter-labs/era-consensus/actions/runs/10215658697/job/28265688492?pr=169
See the link in the error messages to
cargo-denyPR 611 which describes the new behaviour, and then the link to PR 606 which explains why the fields were removed.I don't think the deprecated fields need to be moved, the explanation says they made no sense; except for
[graph].target.Why ❔
So that we can keep using the latest version of
cargo-denywithout failing the build.