Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve error definitions #15

Merged
merged 2 commits into from
Oct 28, 2023
Merged

chore: Improve error definitions #15

merged 2 commits into from
Oct 28, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 27, 2023 •
edited
Loading

What ❔

  • Improve formatting of errors defined using thiserror::Error macro.
  • Use strongly typed errors for block validation.

Why ❔

Improves code style; makes it possible to test errors without relying on their messages.

@slowli slowli marked this pull request as ready for review October 27, 2023 10:28
@brunoffranca brunoffranca merged commit 1c6e578 into main Oct 28, 2023
4 checks passed
@brunoffranca brunoffranca deleted the aov-bft-359-improve-error-definitions branch October 28, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

@brunoffranca brunoffranca brunoffranca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @pompon0 @brunoffranca