Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small type typo in parameter_classes.h (v2.0.0) #36

Open
obandomarcos opened this issue Aug 14, 2022 · 0 comments
Open

Small type typo in parameter_classes.h (v2.0.0) #36

obandomarcos opened this issue Aug 14, 2022 · 0 comments

Comments

@obandomarcos
Copy link

Hi!

First of all, I'd like to appreciate the neat work @matteo-ronchetti has been doing on Torch-Radon!

I wanted to report a small typo that arises a compilation error when building Torch-Radon v2.0.0. In parameter_classes.h, both get_block_dim and get_grid_size headers return a wrong type inside ExecCfg class. I believe they should return vec3 instead of dim3.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant