Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current sync server needs to be rewritten to support different streams #212

Closed
erikjohnston opened this issue Sep 6, 2017 · 1 comment
Closed

Current sync server needs to be rewritten to support different streams #212

erikjohnston opened this issue Sep 6, 2017 · 1 comment
Labels
C-Sync-API

Comments

@erikjohnston
Copy link
Member

Currently its a hack to just support messages. While things like account data can be hacked on top, we probably want to fix it sooner rather than later.

See: #211
NegativeMjark added a commit that referenced this issue Sep 19, 2017
@NegativeMjark
Use a shared PostgreSQL sequence to generate ids.
21d61e4 
Share an auto incrementing sequnce between the account data and
the room event table.
This means that account data updates can be received independantly of
room events updates.

This should give some basic support for fixing #212
@NegativeMjark NegativeMjark mentioned this issue Sep 19, 2017
Merged
NegativeMjark added a commit that referenced this issue Sep 19, 2017
@NegativeMjark
Use a shared PostgreSQL sequence to generate ids. (#237)
b91b3e7 
* Use a shared PostgreSQL sequence to generate ids.

Share an auto incrementing sequnce between the account data and
the room event table.
This means that account data updates can be received independantly of
room events updates.

This should give some basic support for fixing #212

* Remove redundant 'primary key'

* Re-number the SQL arguments

* Fewer lies in comments
@NegativeMjark
Copy link
Contributor

The sync server now happily supports multiple streams by using a shared postgres sequence to generate IDs. This will have scaling issues if we need to run multiple sync server instances, but that is tracked by #211 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Sync-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NegativeMjark @erikjohnston