From 09b4a4b6ab688fafa997abfe38d2064eec1617d7 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Tue, 7 Sep 2021 15:52:59 -0500 Subject: [PATCH] Add tests to verify ?chunk_id actually corresponds to an insertion event that exists Add tests for: - https://github.com/matrix-org/synapse/pull/10776 --- tests/msc2716_test.go | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tests/msc2716_test.go b/tests/msc2716_test.go index ee4e9ac1..96ff9c20 100644 --- a/tests/msc2716_test.go +++ b/tests/msc2716_test.go @@ -345,6 +345,29 @@ func TestBackfillingHistory(t *testing.T) { ) }) + t.Run("Unrecognised chunk_id will throw an error", func(t *testing.T) { + t.Parallel() + + roomID := as.CreateRoom(t, createPublicRoomOpts) + alice.JoinRoom(t, roomID, nil) + + eventIDsBefore := createMessagesInRoom(t, alice, roomID, 1) + eventIdBefore := eventIDsBefore[0] + timeAfterEventBefore := time.Now() + + batchSendHistoricalMessages( + t, + as, + roomID, + eventIdBefore, + "XXX_DOES_NOT_EXIST_CHUNK_ID", + createJoinStateEventsForBackfillRequest([]string{virtualUserID}, timeAfterEventBefore), + createMessageEventsForBackfillRequest([]string{virtualUserID}, timeAfterEventBefore, 1), + // Status + 400, + ) + }) + t.Run("Normal users aren't allowed to backfill messages", func(t *testing.T) { t.Parallel()