Pluggy 1.4.0 now warns about deprecated hook wrapper style

[neutrinoceros]

Pluggy 1.4.0 was released a couple hours ago.
It nows warns about old-style hook wrappers:

pytest-mpl/pytest_mpl/plugin.py

Lines 762 to 763 in db0ea36

	@pytest.hookimpl(hookwrapper=True)
	def pytest_runtest_call(self, item): # noqa

pytest-mpl/pytest_mpl/plugin.py

Lines 930 to 931 in db0ea36

	@pytest.hookimpl(hookwrapper=True)
	def pytest_runtest_call(self, item):

See the release notes and docs.

[pllim]

Hmm, so the force_exception added in #219 didn't fix this problem? Does that mean #216 is needed sooner than later?

[neutrinoceros]

#219 fixed an incompatibility with pytest 8.1, but the new warning is coming from pluggy itself.

I supposed this could be closed as a dupe of #216 actually. Sorry about the noise !

[pllim]

@neutrinoceros , are you sure #219 didn't fix the problem in astropy ? CircleCI is also green with dev version of pytest-mpl (astropy/astropy#15942). Maybe instead of implementing #216 , all we need is a new release of pytest-mpl (which would be faster to do and is needed anyway since the last release was 2 years ago).

[pllim]

Now I am confused, see astropy/astropy#15929 (comment)

[neutrinoceros]

Well I'm sure that #216 needs to happen to fix the problem I reported here, but I'm as confused as you are regarding the apparent flakiness of CI.
I also don't get how #219 is supposed to fix astropy's CI if it's not released yet.

[pllim]

is supposed to fix astropy's CI if it's not released yet

It cannot officially "fix the CI" but would indicate a new patch here isn't necessary, just a new release. But again, maybe I was just lucky that it passed using dev version of pytest-mpl if the failures don't pop up all the time. 🤷‍♀️

[ConorMacBride]

If the only error you are seeing is PluggyTeardownRaisedWarning, that should be fixed on the the main branch of pytest-mpl. The pluggy release notes links the new warning to pytest-dev/pluggy#463, which was motivated by me seeing a misleading error message in pytest-dev/pytest#11714.

When I was seeing that error before (i.e. error raised in teardown) it was very flaky. It appeared in different tests every time I ran pytest. If you temporarily replace image: pytest-mpl with image: git+https://github.com/matplotlib/pytest-mpl.git in /tox.ini in astropy/astropy#15929 and allow pluggy 1.4, the image tests will hopefully run without any issues.

There's just one PR that needs reviewed and merged before a new pytest-mpl release can be published.

[neutrinoceros]

Thanks a lot for the clarification @ConorMacBride !