This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev1644
suggested changes
Nov 7, 2023
} | ||
// new: bridge POL as MATIC, child chain behaviour does not change | ||
else if (_token == registry.contractMap(keccak256("pol"))) { | ||
_token == registry.contractMap(keccak256("matic")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this should be =
instead of ==
@simonDos ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it in the commit below and expanded the test to catch it. @dev1644
simonDos
force-pushed
the
plasma-bridge-update
branch
from
November 9, 2023 11:38
b0ccafe
to
a7d9144
Compare
dev1644
approved these changes
Nov 9, 2023
fix depositBulk using mapToken
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plasma Bridge Modifications
The plasma bridge will be modified to bridge POL for users trying to bridge MATIC after the upgrade.
The following changes will be made:
A convenience functionality has been added in
_createDepositBlock
, which automatically converts MATIC to POL when a user tries to bridge MATIC._createDepositBlock
as well, changing the token address to MATIC before syncStatetransferAssets
to pay out POL instead of MATICInternally, the MATIC address will still be used for all POL bridging operations, as the behaviour of the native token on the PoS side will not be modified and thus can keep operating as usual.
Addresses for the root MATIC contract, the new POL address, as well as the PolygonMigration contract will be added to the registry using
updateContractMap
using “matic”, “pol” and “polygonMigration” as keys.