Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newenvironment with "old" environment not working #1137

Open
zorkow opened this issue Oct 7, 2024 · 4 comments
Open

Newenvironment with "old" environment not working #1137

zorkow opened this issue Oct 7, 2024 · 4 comments
Assignees
Milestone

Comments

@zorkow
Copy link
Member

zorkow commented Oct 7, 2024

Example:

\newenvironment{boxed}
    {
    \begin{array}{|c|c|}\hline
    }
    {
    \\\hline
    \end{array} 
    }
\begin{boxed}a&b\\c&d\end{boxed}

Worked fine in 3.2.2, stopped working in 4.0.0-alpha.1.

@zorkow zorkow self-assigned this Oct 7, 2024
@zorkow zorkow added this to the v4.0 milestone Oct 7, 2024
@dpvc
Copy link
Member

dpvc commented Oct 7, 2024

I suspect 9ed1360 is the commit that is the culprit, but need to look further

@dpvc
Copy link
Member

dpvc commented Oct 7, 2024

The issue that commit fixed is described in #856.

@zorkow
Copy link
Member Author

zorkow commented Oct 7, 2024

Thanks. Tested and lgtm. writes the reviewer confidently. That's because we did not have a complete set of tests!

@dpvc
Copy link
Member

dpvc commented Oct 8, 2024

That's because we did not have a complete set of tests!

Yes, certainly. I know you are working on that, and I will, too.

I have made a PR to fix the problem. Sorry about the duplicate PRs, the first was opened as a draft, and I couldn't find where to change that, so resubmitted it.

dpvc added a commit that referenced this issue Oct 10, 2024
Fix incorrect handling of user-defined environments introduced in #856 (#1137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants