From 3ed78d061f1795315b2eec054a9ab1212212a301 Mon Sep 17 00:00:00 2001 From: Mateusz Baran Date: Tue, 30 Jan 2024 13:01:15 +0100 Subject: [PATCH 1/2] minor change --- src/ImprovedHagerZhangLinesearch.jl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ImprovedHagerZhangLinesearch.jl b/src/ImprovedHagerZhangLinesearch.jl index a20c086..3bfa492 100644 --- a/src/ImprovedHagerZhangLinesearch.jl +++ b/src/ImprovedHagerZhangLinesearch.jl @@ -18,7 +18,7 @@ using Manopt: max_stepsize, get_cost_function # on the parameters mutable struct HagerZhangLinesearch{ - T,TRM<:AbstractRetractionMethod,VTM<:AbstractVectorTransportMethod,P,TX + T<:Real,TRM<:AbstractRetractionMethod,VTM<:AbstractVectorTransportMethod,P,TX } <: Linesearch delta::T # c_1 Wolfe sufficient decrease condition sigma::T # c_2 Wolfe curvature condition (Recommend 0.1 for GradientDescent) @@ -51,11 +51,11 @@ function HagerZhangLinesearch( gamma::T=0.66, linesearchmax::Int=50, psi3::T=0.1, -) where {P,TRM<:AbstractRetractionMethod,VTM<:AbstractVectorTransportMethod,T,TX} +) where {P,TRM<:AbstractRetractionMethod,VTM<:AbstractVectorTransportMethod,T<:Real,TX} return HagerZhangLinesearch{T,TRM,VTM,P,TX}( delta, sigma, - alphamax, + convert(T, alphamax), rho, epsilon, gamma, @@ -124,6 +124,7 @@ function (ls::HagerZhangLinesearch)(ϕdϕ, c::T, phi_0::Real, dphi_0::Real) wher throw(ErrorException("Value and slope at step length = 0 must be finite.")) end if dphi_0 >= eps(T) * abs(phi_0) + println("Values: $dphi_0, $(abs(phi_0))") throw(ErrorException("Search direction is not a direction of descent.")) elseif dphi_0 >= 0 return zeroT, phi_0 From 14321e614fab3c99a4bb47797f8a30697ab33365 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 5 Feb 2024 07:58:30 +0000 Subject: [PATCH 2/2] Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 78251d5..3c11648 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-runtest@v1 - uses: julia-actions/julia-processcoverage@v1 - - uses: codecov/codecov-action@v3 + - uses: codecov/codecov-action@v4 with: file: ./lcov.info name: codecov-umbrella