Skip to content

Commit

Permalink
give VS build tools a try
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielYang59 committed Sep 26, 2024
1 parent 5e824a4 commit 68190a6
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
10 changes: 10 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,16 @@ jobs:
run: |
micromamba install -n pmg -c conda-forge bader enumlib openff-toolkit packmol pygraphviz tblite --yes
- name: Install Visual Studio build tools on Windows
# TODO: remove this, as install these just to build
# a single package is too much
if: matrix.config.os == 'windows-latest'
run: |
choco install visualstudio2022buildtools --include-optional
choco install visualstudio2022-workload-vctools
call "C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat"
- name: Install pymatgen and dependencies via uv
run: |
micromamba activate pmg
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ optional = [
"ase>=3.23.0",
"beautifulsoup4",
# BoltzTraP2 build fails on Windows GitHub runners
"BoltzTraP2>=24.9.4 ; platform_system != 'Windows'",
# "BoltzTraP2>=24.9.4 ; platform_system != 'Windows'",
"BoltzTraP2>=24.9.4",
"chemview>=0.6",
"chgnet>=0.3.8",
"f90nml>=1.1.2",
Expand Down

0 comments on commit 68190a6

Please sign in to comment.