Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autocomplete): cover autocomplete component #487

Merged

Conversation

IvanPostu
Copy link
Member

@IvanPostu IvanPostu commented Jun 23, 2024

related to #479
add tests autocomplete component, for destroy,
selectOption and setValues methods

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

add tests autocomplete component, for destroy,
selectOption and setValues methods
wuda-io
wuda-io previously approved these changes Aug 8, 2024
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io changed the base branch from main to v2-dev August 8, 2024 16:49
@wuda-io wuda-io dismissed their stale review August 8, 2024 16:49

The base branch was changed.

@wuda-io wuda-io merged commit 4c88e1f into materializecss:v2-dev Aug 8, 2024
1 check passed
@wuda-io
Copy link
Member

wuda-io commented Aug 8, 2024

Hey @IvanPostu thanks for your contributions! I will send you an invitation.
Looking forward seeing some nice code from you. cu

@IvanPostu
Copy link
Member Author

Glad to help! I've received the invitation and am happy to be a member of the materializecss community.

wuda-io added a commit that referenced this pull request Aug 29, 2024
@wuda-io wuda-io mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants