fix(labs): allow validators to report customError #5310
Conversation
christophe-g
changed the title
asyncLiz
changed the title
| expect(invalidListener).toHaveBeenCalledWith(jasmine.any(Event)); | ||
| }); | ||
| it('should report custom validation message over other validation messages', () => { | ||
| const control = new TestCustomErrorConstraintValidation(); |
There was a problem hiding this comment.
I think this test needs control.required = true to ensure other validation is running
There was a problem hiding this comment.
Thanks @asyncLiz
I think this is covered in other tests above in the same file. Here we are just making sure that a customError is properly reported as an error (the new test validator in the test file just does that: this.control.setCustomValidity('validator custom error');).
Those 3 new tests fail without the fix in labs/behaviors/constraint-validation.ts. They pass after changing it to:
const customError = !!this[privateCustomValidationMessage] || validity.customError;| if (!this.control) { | ||
| this.control = document.createElement('input'); | ||
| } | ||
| this.control.setCustomValidity('validator custom error'); |
There was a problem hiding this comment.
This needs this.control.required = state.required to support the multi-validation test
There was a problem hiding this comment.
Same comment as above: we only care about customError as this is not working properly with the current codebase.
christophe-g
force-pushed
the
cg-fix-validator-custom-error
branch
from
d3289ca
to
770623c
Compare
Fixes #5302
Following discussion in #5302.