Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Bug fix: Bottom App Bar incorrect offset #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lane-faison
Copy link

@lane-faison lane-faison commented Oct 11, 2019

When adding the Bottom App Bar to a view AND setting the value for isFloatingButtonHidden to true, the Bottom App Bar is shifted down 38px, and cannot be placed in the correct position without setting this value to 0.

This problem was discovered on iOS 13.1, iPhone 8+

In the picture below, the Bottom App Bar was added, and was pinned to the leading, trailing, and bottom edge of the superview, with a height of 56.

Before: static const CGFloat kMDCBottomAppBarNavigationViewYOffset = 0;
Screen Shot 2019-10-11 at 11 01 48 AM

After: static const CGFloat kMDCBottomAppBarNavigationViewYOffset = 0;
Screen Shot 2019-10-11 at 11 02 52 AM

When adding the Bottom App Bar to a view AND setting the value for `isFloatingButtonHidden` to `true`, the Bottom App Bar is shifted down 38px, and cannot be placed in the correct position without setting this value to 0.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lane-faison
Copy link
Author

@googlebot I signed it!

1 similar comment
@mehulparmar4ever
Copy link

@googlebot I signed it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants