Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TabLayout] (proposal) ripple #4296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TabLayout] (proposal) ripple #4296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/java/com/google/android/material/tabs/TabLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2552,6 +2552,10 @@ private void updateBackgroundDrawable(Context context) {
((GradientDrawable) contentDrawable).setColor(Color.TRANSPARENT);

if (tabRippleColorStateList != null) {
GradientDrawable mask = new GradientDrawable();
mask.setCornerRadius(context.getResources().getDisplayMetrics().density * 40);
mask.setColor(Color.WHITE);

GradientDrawable maskDrawable = new GradientDrawable();
// TODO: Find a workaround for this. Currently on certain devices/versions,
// LayerDrawable will draw a black background underneath any layer with a non-opaque color,
Expand All @@ -2568,7 +2572,7 @@ private void updateBackgroundDrawable(Context context) {
new RippleDrawable(
rippleColor,
unboundedRipple ? null : contentDrawable,
unboundedRipple ? null : maskDrawable);
unboundedRipple ? mask : maskDrawable);
} else {
background = contentDrawable;
}
Expand Down