Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Fix drawable compositing on API < 23 #4166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Internal] Fix drawable compositing on API < 23 #4166

wants to merge 1 commit into from

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented May 8, 2024

No description provided.

@leticiarossi
Copy link
Contributor

Thank you for the PR! Could you explain what was the issue in APIs<23 and how does your change fix it? Why are you removing the shouldScaleTopLayer check?

@pubiqq
Copy link
Contributor Author

pubiqq commented May 10, 2024

This "optimization" is just incorrect. If the desired size is INTRINSIC_SIZE, it doesn't mean that the image doesn't need to be scaled, because the topLayerNewWidth and topLayerNewHeight may differ from the desired ones.

I have no idea why shouldScaleTopLayer was added, it wasn't in the original PR.

@pubiqq pubiqq force-pushed the internal/fix-drawable-compositing branch from 034e8c5 to f385bad Compare August 13, 2024 11:47
@pubiqq pubiqq mentioned this pull request Sep 23, 2024
Open
@pubiqq
Copy link
Contributor Author

pubiqq commented Nov 14, 2024

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pubiqq @leticiarossi