You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During debugging I found that in a lot of the turtle code boost::optional instances are passed by value. This leads to a constructor and destructor call on each call making debugging a failure harder than it needs to be.
I'd suggest to accept those optionals by const& instead.
The text was updated successfully, but these errors were encountered:
I guess that depends on the Boost version but generally they should be able to be moved, but in the code they are not. In any case as this is a test library this is usually used in non-optimized builds where even moved optionals are costly: There are quite some functions to be called to determine how to move/copy an optional (check for empty etc) and those make debugging harder/longer
During debugging I found that in a lot of the turtle code
boost::optional
instances are passed by value. This leads to a constructor and destructor call on each call making debugging a failure harder than it needs to be.I'd suggest to accept those optionals by
const&
instead.The text was updated successfully, but these errors were encountered: